Fix inability to parse TMDs with >1024 contents #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Oh wow, thanks for the pull request. Just out of curiosity, where/what title did this TMD come from? |
Author
|
Title |
Collaborator
|
Thank you for this pull request. |
Collaborator
|
This has been released as CTRTool v1.3.0, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title pretty much sums it up. Because ctrtool assumed that all TMDs have only one cmd group, further parsing fails as after TMD deserialisation, the implementation attempts to read a cert chain, which results in it reading into other content info data.
The fix here is to properly read all the cmd groups and hashing each to ensure all content infos are read.